[webkit-reviews] review granted: [Bug 125866] Revise filter-build-webkit to deal with Windows logs : [Attachment 219440] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 125866: Revise filter-build-webkit to deal with Windows logs
https://bugs.webkit.org/show_bug.cgi?id=125866

Attachment 219440: Patch
https://bugs.webkit.org/attachment.cgi?id=219440&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219440&action=review


r=me

> Tools/Scripts/filter-build-webkit:92
> +..-p|--platform Logfile type (default: mac)

What are the periods for?

Would be nice if you used $platform here in case the default ever changes.  :)

  -p|--platform Logfile type (default: $platform)