[webkit-reviews] review granted: [Bug 125854] [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing : [Attachment 219427] Patch proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 125854: [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=125854

Attachment 219427: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=219427&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219427&action=review


r+ with minor nits

> LayoutTests/accessibility/loading-iframe-updates-axtree.html:-28
> -		   shouldBeFalse("subwebarea.isEqual(newSubwebarea)");

can we change this to
newSubwebarea.isEqual(subwebarea)

so that we check that subwebarea has actually disappeared

> Tools/ChangeLog:9
> +	   wrapping invalid platform-specific accessibility objectsin DRT,

objectsin -> objects in