[webkit-reviews] review granted: [Bug 125592] AX: make aria-hidden=false work with subtrees : [Attachment 219430] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 17 12:01:42 PST 2013
Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 125592: AX: make aria-hidden=false work with subtrees
https://bugs.webkit.org/show_bug.cgi?id=125592
Attachment 219430: patch
https://bugs.webkit.org/attachment.cgi?id=219430&action=review
------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219430&action=review
Lgtm. I've just have a suggestion to replace shouldBe() with debug(), see it
below...
> LayoutTests/accessibility/aria-hidden-false-works-in-subtrees.html:35
> + shouldBe("iframeChild.role", "'AXRole: AXGroup'");
Could you replace this shouldBe() with a debug() line before landing, to make
it more cross-platform friendly?
More information about the webkit-reviews
mailing list