[webkit-reviews] review granted: [Bug 125808] GraphicsContext3D too awesome for VS2013 : [Attachment 219381] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 17 09:12:49 PST 2013


Darin Adler <darin at apple.com> has granted Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 125808: GraphicsContext3D too awesome for VS2013
https://bugs.webkit.org/show_bug.cgi?id=125808

Attachment 219381: Patch
https://bugs.webkit.org/attachment.cgi?id=219381&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219381&action=review


> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1614
> +// Visual Studio crashes with a C1063 Fatal Error if this is inlined.
> +#if COMPILER(MSVC)
> +#define ALWAYS_INLINE_EXCEPT_MSVC
> +#else
> +#define ALWAYS_INLINE_EXCEPT_MSVC ALWAYS_INLINE
> +#endif

I’d stick this at the top of the file, not way down here.


More information about the webkit-reviews mailing list