[webkit-reviews] review granted: [Bug 125821] Avoid indirect function calls for custom getters : [Attachment 219379] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 16 18:39:40 PST 2013


Mark Hahnenberg <mhahnenberg at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 125821: Avoid indirect function calls for custom getters
https://bugs.webkit.org/show_bug.cgi?id=125821

Attachment 219379: Patch
https://bugs.webkit.org/attachment.cgi?id=219379&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219379&action=review


r=me

> Source/JavaScriptCore/ChangeLog:13
> +	   Unfortunately this only works in JSVALUE64 at the moment as there
> +	   is not an obvious way to pass two EncodedJSValues uniformly over
> +	   the various effected JITs.

Maybe file a followup bug for 32-bit?


More information about the webkit-reviews mailing list