[webkit-reviews] review granted: [Bug 125816] DatabaseProcess: Plumb through messaging for the 4 basic transaction operations : [Attachment 219370] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 125816: DatabaseProcess: Plumb through messaging for the 4 basic
transaction operations
https://bugs.webkit.org/show_bug.cgi?id=125816

Attachment 219370: Patch v1
https://bugs.webkit.org/attachment.cgi?id=219370&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219370&action=review


r=me

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:234
> +	   LOG_ERROR("Attempting to queue transaction operation when an
operation is already pending");

An operation or the operation? Should it be an assertion?

I guess I'm not sure what this error means, besides "ping Brady on IRC" :)

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:255
> +

Looks like too much whitespace.