[webkit-reviews] review granted: [Bug 125646] [iOS] Upstream WebCore/dom changes : [Attachment 219108] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 16 16:45:31 PST 2013


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 125646: [iOS] Upstream WebCore/dom changes
https://bugs.webkit.org/show_bug.cgi?id=125646

Attachment 219108: Patch
https://bugs.webkit.org/attachment.cgi?id=219108&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219108&action=review


r=me

> Source/WebCore/dom/DOMImplementation.cpp:352
> -#if ENABLE(VIDEO)
> +#if ENABLE(VIDEO) && !PLATFORM(IOS)

Would this be written better as:

#if ENABLE(VIDEO) && !ENABLE(PLUGIN_PROXY_FOR_VIDEO)


More information about the webkit-reviews mailing list