[webkit-reviews] review granted: [Bug 125678] CStack Branch: Use proper values to setting up the stack pointer register : [Attachment 219154] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 125678: CStack Branch: Use proper values to setting up the stack pointer
register
https://bugs.webkit.org/show_bug.cgi?id=125678

Attachment 219154: Patch
https://bugs.webkit.org/attachment.cgi?id=219154&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think it would be nice, in a follow-up patch, to move the register math into
shared helper functions named something like "frameExtentInBytes". There should
be one of these functions per engine, since the engines have different frame
extent requirements. So, you might have:

addPtr(TrustedImm32(m_graph.frameExtentInBytes(), GPRInfo::callFrameRegister,
stackPointerRegister);

It's easier to see that this piece of our logic is correct when it has a name
like this.