[webkit-reviews] review granted: [Bug 125807] Apply overhang shadow and linen to UI-side layers : [Attachment 219359] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 125807: Apply overhang shadow and linen to UI-side layers
https://bugs.webkit.org/show_bug.cgi?id=125807

Attachment 219359: Patch
https://bugs.webkit.org/attachment.cgi?id=219359&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219359&action=review


> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:560
> +    RetainPtr<CGPathRef> shadowPath =
adoptCF(CGPathCreateWithRect(layer.bounds, NULL));
> +    layer.shadowPath = shadowPath.get();

not sure this temporary is useful

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:565
> +    layer.shadowPath = nil;

I think you should drop shadow opacity too, otherwise CA will try to figure out
the opaque region of the layer because it doesn't have a shadowPath.

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:652
> +	   if (layerProperties.changedProperties &
RemoteLayerTreeTransaction::CustomAppearanceChanged)
> +	       dumpProperty<GraphicsLayer::CustomAppearance>(ts,
"customAppearance", layerProperties.customAppearance);
> +

Ideally this would print something useful but not necessary right now.

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:529
> +void
PlatformCALayerRemote::updateCustomAppearance(WebCore::GraphicsLayer::CustomApp
earance customAppearance)

No WebCore:: here