[webkit-reviews] review granted: [Bug 125791] CStack Branch: Eliminate topOfStack parameter from callToJavaScript() and callToNativeFunction() : [Attachment 219335] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 125791: CStack Branch: Eliminate topOfStack parameter from
callToJavaScript() and callToNativeFunction()
https://bugs.webkit.org/show_bug.cgi?id=125791

Attachment 219335: Patch
https://bugs.webkit.org/attachment.cgi?id=219335&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219335&action=review


r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:468
> +# EncodedJSValue callToJavaScript(void* code, VM* vm, ProtoCallFrame*
protoFrame)
> +# EncodedJSValue callToNativeFunction(void* code, VM* vm, ProtoCallFrame*
protoFrame)

Please change this from VM* to ExecState**. As Mark pointed out, this doesn't
match our declaration. Callers pass &vm.topCallFrame, which is an ExecState**.