[webkit-reviews] review granted: [Bug 125649] cStack: Calling into FTL-generated code should be fast : [Attachment 219254] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 125649: cStack: Calling into FTL-generated code should be fast
https://bugs.webkit.org/show_bug.cgi?id=125649

Attachment 219254: the patch
https://bugs.webkit.org/attachment.cgi?id=219254&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219254&action=review


r=me

> Source/JavaScriptCore/runtime/Options.h:211
> +    v(bool, disableGC, false) \

I prefer for settings like this to be stated in the affirmative: "enableGC",
defaulting to true. "Don't disable GC" is a hard phrase to parse.