[webkit-reviews] review granted: [Bug 125769] [iOS] Upstream WebCore/history : [Attachment 219301] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 125769: [iOS] Upstream WebCore/history
https://bugs.webkit.org/show_bug.cgi?id=125769

Attachment 219301: Patch
https://bugs.webkit.org/attachment.cgi?id=219301&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219301&action=review


> Source/WebCore/history/CachedPage.cpp:103
> +#if !PLATFORM(IOS)
>      if (Element* element = focusedDocument->focusedElement())
>	   element->updateFocusAppearance(true);
> +#else
> +    if (Element* element = focusedDocument->focusedElement()) {
> +	   // We don't want focused nodes changing scroll position when
restoring from the cache
> +	   // as it can cause ugly jumps before we manage to restore the cached
position.
> +	   page.mainFrame().selection().suppressScrolling();
> +	   element->updateFocusAppearance(true);
> +	   page.mainFrame().selection().restoreScrolling();
> +    }
> +#endif

The #if should be around the calls to suppress/restoreScrolling, not around the
entire block.