[webkit-reviews] review granted: [Bug 125784] [iOS] Upstream WebCore/svg changes : [Attachment 219323] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 125784: [iOS] Upstream WebCore/svg changes
https://bugs.webkit.org/show_bug.cgi?id=125784

Attachment 219323: Patch
https://bugs.webkit.org/attachment.cgi?id=219323&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review


> Source/WebCore/svg/SVGAElement.cpp:239
> +#if PLATFORM(IOS)
> +bool SVGAElement::willRespondToMouseClickEvents()

I see no reason for this to be iOS-specific. Seems like we want it on all
platforms.

> Source/WebCore/svg/SVGAElement.cpp:241
> +    return !href().isEmpty() ||
SVGGraphicsElement::willRespondToMouseClickEvents(); 

Should check isLink() rather than !href().isEmpty().

> Source/WebCore/svg/SVGElement.cpp:494
> +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)

Not sure I understand why the PLATFORM(IOS) is here.