[webkit-reviews] review granted: [Bug 125762] CTTE: Convert more of SVG to use references : [Attachment 219292] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 125762: CTTE: Convert more of SVG to use references
https://bugs.webkit.org/show_bug.cgi?id=125762

Attachment 219292: Patch
https://bugs.webkit.org/attachment.cgi?id=219292&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219292&action=review


Looks great. I spotted 6 “other places” you didn’t change.

> Source/WebCore/svg/SVGAnimateMotionElement.cpp:292
> +    if (RenderElement* renderer = targetElement->renderer())

One of the “other places”.

> Source/WebCore/svg/SVGAnimateMotionElement.cpp:307
> +	   if (RenderElement* renderer = shadowTreeElement->renderer()) {

Another of the “other places”.

> Source/WebCore/svg/SVGFEImageElement.cpp:202
> +    RenderElement* parentRenderer = parent->renderer();

Another of the “other places”.

> Source/WebCore/svg/SVGFELightElement.cpp:217
> +    RenderElement* renderer = parent->renderer();

Another of the “other places”.

> Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp:168
> +    RenderElement* renderer = parent->renderer();

Another of the “other places”.

> Source/WebCore/svg/SVGSVGElement.cpp:726
> +		   if (RenderElement* renderer = svg->renderer())

Another of the “other places”.