[webkit-reviews] review granted: [Bug 125737] Page::theme() should return a reference. : [Attachment 219249] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 14 05:51:40 PST 2013


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 125737: Page::theme() should return a reference.
https://bugs.webkit.org/show_bug.cgi?id=125737

Attachment 219249: Patch
https://bugs.webkit.org/attachment.cgi?id=219249&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=219249&action=review


> Source/WebCore/page/Page.h:144
> -    RenderTheme* theme() const { return m_theme.get(); }
> +    RenderTheme& theme() const { return *m_theme; }

We might want to have separate const and non-const versions.


More information about the webkit-reviews mailing list