[webkit-reviews] review granted: [Bug 125703] [MSE] Update duration after appending samples, per spec. : [Attachment 219187] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 125703: [MSE] Update duration after appending samples, per spec.
https://bugs.webkit.org/show_bug.cgi?id=125703

Attachment 219187: Patch
https://bugs.webkit.org/attachment.cgi?id=219187&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219187&action=review


> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1010
> +    if (highestPresentationEndTimestamp().toDouble() > m_source->duration())

> +	   m_source->setDuration(highestPresentationEndTimestamp().toDouble(),
IgnorableExceptionCode());

Nit: it will be more efficient to put the timestamp in a variable instead of
calculating it twice.

> LayoutTests/media/media-source/media-source-duration-after-append.html:16
> +    function runTest() {

Nit: wrong place for the opening brace.