[webkit-reviews] review granted: [Bug 125699] [WK2] Start removing calls to String::characters() : [Attachment 219182] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 13 12:49:43 PST 2013


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 125699: [WK2] Start removing calls to String::characters()
https://bugs.webkit.org/show_bug.cgi?id=125699

Attachment 219182: Patch
https://bugs.webkit.org/attachment.cgi?id=219182&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219182&action=review


> Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:55
> +    RetainPtr<CFStringRef> directoryCFString = directory.createCFString();

auto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:912
> +	   loadDataImpl(sharedBuffer, MIMEType, ASCIILiteral("utf-8"), baseURL,
unreachableURL, decoder);

This has to be latin-1.


More information about the webkit-reviews mailing list