[webkit-reviews] review granted: [Bug 125546] [WebGL] Check for global variable precision mismatch between vertex and fragment shaders : [Attachment 218923] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 125546: [WebGL] Check for global variable precision mismatch between vertex
and fragment shaders
https://bugs.webkit.org/show_bug.cgi?id=125546

Attachment 218923: Patch
https://bugs.webkit.org/attachment.cgi?id=218923&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218923&action=review


r=me, but consider using "auto" and revising the loop to use prefix ++.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:337

> +    for (ShaderSymbolMap::iterator it = vertexEntry.uniformMap.begin(); it
!= vertexEntry.uniformMap.end(); it.operator++()) {

This could be "auto it = ..."

Also, why do you need to write it.operator++? Does ++it not work?

We prefer "++it" because it has a performance benefit (at least in older
compilers).

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:341

> +    for (ShaderSymbolMap::iterator it = fragmentEntry.uniformMap.begin(); it
!= fragmentEntry.uniformMap.end(); it.operator++()) {

Ditto about "auto it = ..." and operator++