[webkit-reviews] review granted: [Bug 125695] Web Inspector: provide an abstraction for CodeMirror's TextMarker : [Attachment 219172] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 125695: Web Inspector: provide an abstraction for CodeMirror's TextMarker
https://bugs.webkit.org/show_bug.cgi?id=125695

Attachment 219172: Patch
https://bugs.webkit.org/attachment.cgi?id=219172&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219172&action=review


> Source/WebInspectorUI/UserInterface/CodeMirrorColorEditingController.js:90
> +	   this._range = new WebInspector.TextRange(this._range.startLine,
this._range.startColumn, this._range.endLine, this._range.startColumn +
text.length);

Shouldn't this take into account any "\n" in text when making the endLine and
endColumn? Or just assert no "\n" is allowed in the text and use startLine for
endLine.