[webkit-reviews] review granted: [Bug 125672] jsCStack: Fix exception handling for the LLINT. : [Attachment 219143] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 125672: jsCStack: Fix exception handling for the LLINT.
https://bugs.webkit.org/show_bug.cgi?id=125672

Attachment 219143: the patch.
https://bugs.webkit.org/attachment.cgi?id=219143&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219143&action=review


r=me

>> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:283
>> +	# So far, we've unwound the stack to the farme just above the sentinel
frame.
> 
> Typo: "farme"

The stack grows downward, so I think you meant "below" here, and not "above".

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1971
> +    # So far, we've unwound the stack until the native frame. We need to pop
it,
> +    # and pick up unwinding from its caller now (if needed).

This comment is misleading. We didn't "unwind the stack". Instead, the host
function returned to us in the normal way. A better thing to say here is just
"Pop the host function stack frame created by op_call".

Even that is not a great comment, since it doesn't explain *why*. Why does
_llint_throw_from_native_call need us to pop the host function stack frame? I'm
not sure.