[webkit-reviews] review granted: [Bug 125604] [wk2] Handle pinch-to-zoom gesture : [Attachment 219132] take 4 - addressing lots of review comments

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 125604: [wk2] Handle pinch-to-zoom gesture
https://bugs.webkit.org/show_bug.cgi?id=125604

Attachment 219132: take 4 - addressing lots of review comments
https://bugs.webkit.org/attachment.cgi?id=219132&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219132&action=review


> Source/WebKit2/UIProcess/API/mac/WKView.mm:3302
> +- (void)setMagnification:(double)magnification
> +{
> +    FloatPoint viewCenter(NSMidX([self bounds]), NSMidY([self bounds]));
> +    _data->_page->scalePage(magnification, roundedIntPoint(viewCenter));
> +}

Seems weird to arbitrarily zoom to the center.

> Source/WebKit2/UIProcess/mac/ViewGestureController.h:68
> +    double m_magnification;
> +    WebCore::FloatPoint m_magnificationOrigin;
> +    WebCore::FloatRect m_visibleContentRect;
> +    bool m_visibleContentRectIsValid;
> +
> +    WebPageProxy& m_webPageProxy;

Re-order to save (tiny) space.