[webkit-reviews] review granted: [Bug 125653] CStack Branch: Eliminate unnecessary add/sub 16 to stack pointer : [Attachment 219122] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 125653: CStack Branch: Eliminate unnecessary add/sub 16 to stack pointer
https://bugs.webkit.org/show_bug.cgi?id=125653

Attachment 219122: Patch
https://bugs.webkit.org/attachment.cgi?id=219122&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219122&action=review


r=me

> Source/JavaScriptCore/dfg/DFGGraph.cpp:706
> +    unsigned result = m_nextMachineLocal + std::max(m_parameterSlots,
(unsigned)JSStack::CallerFrameAndPCSize);

static_cast, please.

> Source/JavaScriptCore/dfg/DFGGraph.cpp:707
>      result += result & 1; // Align the register count

This would be better expressed as "result =
roundUpToMultipleOf<stackAlignment>(result);", and no comment.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:44
> +const CallerFrameAndPCSize = 2 * PtrSize

Please add an ASSERT for this to LLIntData.cpp.