[webkit-reviews] review granted: [Bug 125657] Fix a silly mistake of r160467 : [Attachment 219121] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 12 15:06:15 PST 2013
Alexey Proskuryakov <ap at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 125657: Fix a silly mistake of r160467
https://bugs.webkit.org/show_bug.cgi?id=125657
Attachment 219121: Patch
https://bugs.webkit.org/attachment.cgi?id=219121&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219121&action=review
>
Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOpe
rationQueue.cpp:136
> + if (!!protector->hasHandle()) {
Can we just use "if (protector->hasHandle())"?
>
Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOpe
rationQueue.cpp:164
> - if (!protector->hasHandle()) {
> + if (!!protector->hasHandle()) {
Ditto
>
Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOpe
rationQueue.cpp:197
> + if (!!protector->hasHandle()) {
Ditto.
>
Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOpe
rationQueue.cpp:272
> + if (!!protector->hasHandle()) {
Ditto
More information about the webkit-reviews
mailing list