[webkit-reviews] review granted: [Bug 125648] jsCStack: Fix handling of uncaught exceptions : [Attachment 219111] revised patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 12 13:20:22 PST 2013


Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 125648: jsCStack: Fix handling of uncaught exceptions
https://bugs.webkit.org/show_bug.cgi?id=125648

Attachment 219111: revised patch.
https://bugs.webkit.org/attachment.cgi?id=219111&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

Do we need this "bpeq CodeBlock[cfr], 1, .calleeFramePopped / loadp
CallerFrame[cfr], cfr" business? I don't think so. You should look into
removing it. Since we know we're handling an uncaught exception, we know for
certain that callFrameForThrow is the sentinel CallFrame, and we don't need to
test it.


More information about the webkit-reviews mailing list