[webkit-reviews] review canceled: [Bug 125648] jsCStack: Fix the LLINT handling of uncaught exceptions : [Attachment 219110] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 12 13:01:29 PST 2013


Mark Lam <mark.lam at apple.com> has canceled Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 125648: jsCStack: Fix the LLINT handling of uncaught exceptions
https://bugs.webkit.org/show_bug.cgi?id=125648

Attachment 219110: the patch.
https://bugs.webkit.org/attachment.cgi?id=219110&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
I stand corrected.  This patch also fixes uncaught exceptions for the baseline
JIT.  I previously thought it didn't because I had initially implemented the
fix by making llint_slow_handle_exception set the returning ExecState.	I've
since moved the loading of callFrameForThrow to the LLINT
handleUncaughtException thunk which fixes the issue for both the LLINT and the
baseline JIT.  Will fix ChangeLog and upload another patch.


More information about the webkit-reviews mailing list