[webkit-reviews] review granted: [Bug 125604] [wk2] Handle pinch-to-zoom gesture : [Attachment 219023] address review comments (except GraphicsLayer bit)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 12 11:51:56 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 125604: [wk2] Handle pinch-to-zoom gesture
https://bugs.webkit.org/show_bug.cgi?id=125604

Attachment 219023: address review comments (except GraphicsLayer bit)
https://bugs.webkit.org/attachment.cgi?id=219023&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219023&action=review


r=me with some renaming.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:475
> +		0FA24D7A162DF91900A3F4C0 /* GraphicsLayerUpdater.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 0FA24D78162DF91900A3F4C0 /*
GraphicsLayerUpdater.h */; settings = {ATTRIBUTES = (Private, ); }; };

Why?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:1476
> +		49AF2D6914435D050016A784 /* DisplayRefreshMonitor.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 49AF2D6814435D050016A784 /*
DisplayRefreshMonitor.h */; settings = {ATTRIBUTES = (Private, ); }; };

Why?

> Source/WebKit2/ChangeLog:12
> +	   Add ViewGestureController off of WKView, which currently only
handles

"off of"

> Source/WebKit2/ChangeLog:14
> +	   and origin and such, and forwards relevant events on to the
DrawingArea

"and such"

> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:98
> +- (void)_setShouldHandleMagnificationGesture:(BOOL)flag;

flag -> shouldHandle ?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:236
> +    std::unique_ptr<ViewGestureController> _gestureController;

Any reason not to just have one by value?

> Source/WebKit2/UIProcess/DrawingAreaProxy.h:75
> +    virtual void endTransientZoom(double scale, WebCore::FloatPoint origin)
{ }

commitZoom?

> Source/WebKit2/UIProcess/ViewGestureController.cpp:75
> +FloatPoint ViewGestureController::scaledMagnificationOrigin(FloatPoint
origin, double scale)

const FloatPoint&?

> Source/WebKit2/UIProcess/ViewGestureController.cpp:84
> +void ViewGestureController::didBeginTransientZoom(FloatRect
visibleContentRect)

const FloatRect&

> Source/WebKit2/UIProcess/ViewGestureController.cpp:91
> +void ViewGestureController::handleMagnificationGesture(double scale,
FloatPoint origin)

const FloatPoint&?


More information about the webkit-reviews mailing list