[webkit-reviews] review denied: [Bug 125600] Need ObjC APIs for some InjectedBundle classes. : [Attachment 219020] Fix style issue, and autorelease wrapper objects before returning to caller.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 125600: Need ObjC APIs for some InjectedBundle classes.
https://bugs.webkit.org/show_bug.cgi?id=125600

Attachment 219020: Fix style issue, and autorelease wrapper objects before
returning to caller.
https://bugs.webkit.org/attachment.cgi?id=219020&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219020&action=review


>>
Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:41

>> +- (JSGlobalContextRef)jsContextForWorld:(WKWebProcessPlugInScriptWorld
*)world;
> 
> I believe that we should avoid the C JavaScript API types in our Cocoa API,
so this method should return a (JSContext *).

Yeah, this should use the Objective-C JS API.

>
Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:42

> +- (WKWebProcessPlugInHitTestResult *)hitTest:(CGPoint)point;

Can we put HitTest on the browsing controller instead?