[webkit-reviews] review granted: [Bug 119618] Adding a .ycm_extra_conf file for webkitGtk : [Attachment 219016] Iterated version of Danilo's patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 119618: Adding a .ycm_extra_conf file for webkitGtk
https://bugs.webkit.org/show_bug.cgi?id=119618

Attachment 219016: Iterated version of Danilo's patch
https://bugs.webkit.org/attachment.cgi?id=219016&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219016&action=review


LGTM, with a small refactoring proposal for the first function

> Tools/gtk/ycm_extra_conf.py:47
> +	       for flag in FLAGS_PRECEDING_PATHS:

This for block could be replaced by if argument in FLAGS_PRECEDING_PATHS, you
could always ensure argument is either a flag or a path to have a single code
path here, it will be much more readable.

> Tools/gtk/ycm_extra_conf.py:54
> +		   # Some argument contain the flag and the path together. For
these

Missing last bit of the comment?

> Tools/gtk/ycm_extra_conf.py:101
> +	   print "==== Error during reading %s file", trace_file_path

s/during/while/?