[webkit-reviews] review denied: [Bug 125637] Broken error recovery in @media at-rule : [Attachment 219081] Proposed patch with test case

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Martin Hodovan
<hodovanmartin at gmail.com>'s request for review:
Bug 125637: Broken error recovery in @media at-rule
https://bugs.webkit.org/show_bug.cgi?id=125637

Attachment 219081: Proposed patch with test case
https://bugs.webkit.org/attachment.cgi?id=219081&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219081&action=review


Fix looks fine. Test is incorrect, though. Easy to fix.

> LayoutTests/fast/css/media-error-recovery.html:6
> +	if (window.testRunner)
> +	testRunner.dumpAsText();

This is a mistake. The test won’t work if you only dump the text. The test
writes out the same text when it fails as when it succeeds. To make a text-only
test, something in the test has to actually show whether the test has succeeded
or failed.

For an example of one way to do this, please look at the
media-rule-no-whitespace.html test.