[webkit-reviews] review granted: [Bug 125467] PATH needs to include cygwin for WebKitVersion : [Attachment 218801] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 125467: PATH needs to include cygwin for WebKitVersion
https://bugs.webkit.org/show_bug.cgi?id=125467

Attachment 218801: Patch
https://bugs.webkit.org/attachment.cgi?id=218801&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218801&action=review


r=me

> Source/WebKit/WebKit.vcxproj/WebKit/WebKitVersion.cmd:5
> +set PATH=%SystemDrive%\cygwin\bin;%PATH%

This assumes that Cygwin is always installed in "C:\cygwin", which may not be
the case on all user's systems.

Still, it's a reasonable assumption for most people.

We might want to check
"HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Cygwin\setup\rootdir" to get the true
location.