[webkit-reviews] review granted: [Bug 125248] Missing ENABLE(DRAG_SUPPORT) guards for drag-specific DragImage functions : [Attachment 218932] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brian Burg <burg at cs.washington.edu>'s
request for review:
Bug 125248: Missing ENABLE(DRAG_SUPPORT) guards for drag-specific DragImage
functions
https://bugs.webkit.org/show_bug.cgi?id=125248

Attachment 218932: patch
https://bugs.webkit.org/attachment.cgi?id=218932&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218932&action=review


Change seems OK, but also seems that for platforms where DRAG_SUPPORT isn’t
supported, we should leave out the functions for that entirely instead of
having (#if DRAG_SUPPORT, return 0, #endif) placeholders that don’t do anything
useful.

> Source/WebCore/platform/DragImage.h:66
>  // These functions should be memory neutral, eg. if they return a newly
allocated image,
>  // they should release the input image. As a corollary these methods don't
guarantee
>  // the input image ref will still be valid after they have been called.

This comment is only about the three functions that both take and return a
DragImageRef, all of which are inside the #if. I think it’s peculiar to have it
up here where it seems to apply to many other functions.