[webkit-reviews] review granted: [Bug 125598] Give Unique StringImpls a meaningful data pointer : [Attachment 219000] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 11 13:54:32 PST 2013


Michael Saboff <msaboff at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 125598: Give Unique StringImpls a meaningful data pointer
https://bugs.webkit.org/show_bug.cgi?id=125598

Attachment 219000: Patch
https://bugs.webkit.org/attachment.cgi?id=219000&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
r=me, but add a comment in the code that we expect m_buffer to be null.  If we
change StringImpl in the future it will be easier to see why you're doing this
without tracking down the change set / bug.


More information about the webkit-reviews mailing list