[webkit-reviews] review granted: [Bug 115719] [GTK] Add a UPower-based BatteryProvider : [Attachment 218759] Rebased patch.

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 115719: [GTK] Add a UPower-based BatteryProvider
https://bugs.webkit.org/show_bug.cgi?id=115719

Attachment 218759: Rebased patch.
https://bugs.webkit.org/attachment.cgi?id=218759&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218759&action=review


> Source/WebCore/platform/glib/BatteryProviderUPower.cpp:92
> +	   bool isPresent;

This should be gboolean.

> Source/WebCore/platform/glib/BatteryProviderUPowerClient.h:35
> +    virtual void updateBatteryStatus(BatteryProviderUPowerStatus, double
timeRemaining = 0, double level = 0) = 0;

I'd prefer secondsRemaining if that's the unit here. timeRemaining doesn't make
it clear what the unit of the value is. Likewise level might be better termed
fillRatio or something similar.