[webkit-reviews] review requested: [Bug 120284] ASSERTION FAILED: m_context->document()->documentElement() != m_context in WebCore::SVGLengthContext::determineViewport : [Attachment 218946] patch fixes assertion

[bugzilla-daemon at webkit.org]

Tamas Gergely <tgergely.u-szeged at partner.samsung.com> has asked  for review:
Bug 120284: ASSERTION FAILED: m_context->document()->documentElement() !=
m_context in WebCore::SVGLengthContext::determineViewport
https://bugs.webkit.org/show_bug.cgi?id=120284

Attachment 218946: patch fixes assertion
https://bugs.webkit.org/attachment.cgi?id=218946&action=review

------- Additional Comments from Tamas Gergely
<tgergely.u-szeged at partner.samsung.com>
https://chromium.googlesource.com/chromium/blink/+/a7dedf81eb7008276bb6854f0e46
465e039788f8

[SVG] Fix root element length values handling.

SVGLengthContext::determineViewport() currently asserts that we're not
resolving lengths for the topmost element, but there's nothing to
prevent such calls.

The CL updates determineViewport() to handle root elements geracefully
(using their current viewport). It also changes the signature slightly
to operate directly on a FloatSize, reducing some of the boiler-plate
client code.