[webkit-reviews] review requested: [Bug 125528] [MIPS] Redundant instructions in code generated from offlineasm. : [Attachment 218890] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 10 12:29:40 PST 2013


Balazs Kilvady <kilvadyb at homejinni.com> has asked  for review:
Bug 125528: [MIPS] Redundant instructions in code generated from offlineasm.
https://bugs.webkit.org/show_bug.cgi?id=125528

Attachment 218890: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=218890&action=review

------- Additional Comments from Balazs Kilvady <kilvadyb at homejinni.com>
This patch modifies the lowering of BaseIndex addresses to check instructions
in pairs so it can leave out redundant MIPS code.
Redundant MIPS instructions optimized out at 210 times processing the current
LowLevelInterpreter.asm. It is hard to measure the speed of LLInt but
performance test shows a small improvement:
v8-v6: 19001.8ms -> 18855.0ms
SunSpider: 5323.5ms -> 5316.1ms
And at least the size of the code is smaller.


More information about the webkit-reviews mailing list