[webkit-reviews] review granted: [Bug 125502] [EFL][JSC] Enable udis86 disassembler on efl : [Attachment 218866] patch enables udis86 on efl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 10 09:29:38 PST 2013


Michael Saboff <msaboff at apple.com> has granted Tamas Gergely
<tgergely.u-szeged at partner.samsung.com>'s request for review:
Bug 125502: [EFL][JSC] Enable udis86 disassembler on efl
https://bugs.webkit.org/show_bug.cgi?id=125502

Attachment 218866: patch enables udis86 on efl
https://bugs.webkit.org/attachment.cgi?id=218866&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218866&action=review


r=me, but change the (unsigned long long) casts to (uint64_t) casts.

> Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130
> +				mkasm(u, "0x" FMT64 "x", (unsigned long
long)(u->pc + op->lval.sbyte)); 

Please make these casts to uint64_t


More information about the webkit-reviews mailing list