[webkit-reviews] review granted: [Bug 125490] [WK2][SOUP] initialise the Network Process with ignoreTLSErrors : [Attachment 218849] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 125490: [WK2][SOUP] initialise the Network Process with ignoreTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=125490

Attachment 218849: Patch
https://bugs.webkit.org/attachment.cgi?id=218849&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218849&action=review


> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:104
> -    parameters.ignoreTLSErrors = m_ignoreTLSErrors;
>      parameters.shouldTrackVisitedLinks = true;
>  #if ENABLE(NETWORK_PROCESS)
>      parameters.usesNetworkProcess = true;
> +#else
> +    parameters.ignoreTLSErrors = m_ignoreTLSErrors;

Looks good to me, pretty sure we'll need this for cookieAcceptPolicy and others
as well, maybe we should do the others in one go?