[webkit-reviews] review canceled: [Bug 100275] Programmatically-inserted children lack accessibility events : [Attachment 218683] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has canceled Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 100275: Programmatically-inserted children lack accessibility events
https://bugs.webkit.org/show_bug.cgi?id=100275

Attachment 218683: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=218683&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #21)
> [...]
> > By calling
> >  obj->parentObjectUnignored();
> > you still may end up calling accessibilityIsIgnored(). Since this is
happening in attachWrapper,
> > it seems OK because I don't think we create AX objects until they're
requested (but i could be wrong)
> >
> 
> That's right, and so the comment is definitely wrong. Perhaps there's no need
to restrict it to  accessibilityPlatformIncludesObject() and I can just use
accessibilityIsIgnored() directly since, as you pointed it out, it might get
called anyway in parentObjectUnignored. 
> 
> 
> I'll try that and come up with a new atch asap. Thanks for the review

I've tested that suggestion and it works fine indeed both in WK1 and WK2 for
debug and release builds, so I'm updating the patch to use
accessibilityIsIgnoredByDefault() instead.

Again, thanks for pointing that out.