[webkit-reviews] review granted: [Bug 125472] ASSERT !heap.vm()->isInitializingObject() when finishing DFG compilation at beginning of GC : [Attachment 218819] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 125472: ASSERT !heap.vm()->isInitializingObject() when finishing DFG
compilation at beginning of GC
https://bugs.webkit.org/show_bug.cgi?id=125472

Attachment 218819: Patch
https://bugs.webkit.org/attachment.cgi?id=218819&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218819&action=review


r=me

> Source/JavaScriptCore/heap/Heap.cpp:759
> +	   PretendAllocationOkay pretend(*this);

I don't like the word "pretend" here because it implies that we're only
silencing ASSERTs, when in reality we're making material changes that make the
difference between allocating being OK or not. How about
"RecursiveAllocationScope"?

> Source/JavaScriptCore/heap/Heap.cpp:760
> +	   m_vm->prepareToDiscardCode();

Do we need to do this in every GC, or only if we're going to discard code?
Seems weird, and unnecessarily costly, to do this if we're not going to discard
code.