[webkit-reviews] review granted: [Bug 125471] Begin working on a UserData class intended to replace UserMessageCoders : [Attachment 218809] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 125471: Begin working on a UserData class intended to replace
UserMessageCoders
https://bugs.webkit.org/show_bug.cgi?id=125471

Attachment 218809: Patch
https://bugs.webkit.org/attachment.cgi?id=218809&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218809&action=review


> Source/WebKit2/Shared/APIFrameHandle.h:36
> +    static PassRefPtr<FrameHandle> create(uint64_t frameID);

You said that RefPtr would be fine here.

> Source/WebKit2/Shared/APIPageHandle.h:36
> +    static PassRefPtr<PageHandle> create(uint64_t pageID);

RefPtr here please.

> Source/WebKit2/Shared/UserData.cpp:60
> +	   encoder.encodeEnum(API::Object::Type::Null);

You don't deal with decoding this.