[webkit-reviews] review denied: [Bug 125442] webkitpy: remove unused BUILDER_BASE_URL : [Attachment 218739] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 9 14:44:35 PST 2013
Ryosuke Niwa <rniwa at webkit.org> has denied Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>'s request for review:
Bug 125442: webkitpy: remove unused BUILDER_BASE_URL
https://bugs.webkit.org/show_bug.cgi?id=125442
Attachment 218739: Patch
https://bugs.webkit.org/attachment.cgi?id=218739&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218739&action=review
>>> Tools/ChangeLog:7
>>> +
>>
>> Why are we removing it?
>
> It's completely useless, and I don't see any reason why we should keep it
this way. Someone must have forgotten removing it, along with other Chromium
stuff.
Please explain that in the change log.
r- due to the lack of description in the change log.
More information about the webkit-reviews
mailing list