[webkit-reviews] review granted: [Bug 125446] Store SHA1 hash in std::array. : [Attachment 218798] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 9 14:03:44 PST 2013
Darin Adler <darin at apple.com> has granted Laszlo Vidacs <lac at inf.u-szeged.hu>'s
request for review:
Bug 125446: Store SHA1 hash in std::array.
https://bugs.webkit.org/show_bug.cgi?id=125446
Attachment 218798: Patch
https://bugs.webkit.org/attachment.cgi?id=218798&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218798&action=review
> Source/WTF/wtf/SHA1.cpp:95
> + // array not initialized, need to update all positions
True, yet not really a helpful comment. Nor in the format we use for comments
in WebKit.
More information about the webkit-reviews
mailing list