[webkit-reviews] review granted: [Bug 11646] Implement Document.cloneNode() : [Attachment 218776] Fixes the bug

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 11646: Implement Document.cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=11646

Attachment 218776: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=218776&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218776&action=review


> Source/WebCore/dom/Document.cpp:3039
> +    return isXHTMLDocument() ? createXHTML(0, url()) : create(0, url());

nullptr please, not 0

> Source/WebCore/html/HTMLDocument.cpp:370
> +    return create(0, url());

nullptr please, not 0

> Source/WebCore/svg/SVGDocument.cpp:105
> +    return create(0, url());

nullptr please, not 0

> Source/WebCore/svg/SVGDocument.h:56
> +    virtual PassRefPtr<Document> cloneDocumentWithoutChildren() const
OVERRIDE FINAL;

Class is FINAL so no need to mark function FINAL, but I suppose there’s no harm
in it.