[webkit-reviews] review granted: [Bug 118343] [WK2][Soup] Support cache model in NetworkProcess : [Attachment 218743] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Kwang Yul Seo
<skyul at company100.com>'s request for review:
Bug 118343: [WK2][Soup] Support cache model in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=118343

Attachment 218743: Patch
https://bugs.webkit.org/attachment.cgi?id=218743&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218743&action=review


> Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:36
> +

Please, remove this empty line

> Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:40
> +#if USE(SOUP)
> +#include <libsoup/soup.h>
> +#endif

I think we don't need to keep the alphabetic order for headers added inside an
#if block, so I think it's better to move this below right after the #if
PLATFORM(EFL) block

> Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:104
> +#if ENABLE(NETWORK_PROCESS)
> +    if (!m_usesNetworkProcess) {
> +#endif
> +	   SoupSession* session = WebCore::ResourceHandle::defaultSession();
> +	   cache = SOUP_CACHE(soup_session_get_feature(session,
SOUP_TYPE_CACHE));
> +	   diskFreeSize = getCacheDiskFreeSize(cache) / 1024 / 1024;
> +#if ENABLE(NETWORK_PROCESS)
> +    }
> +#endif

I think we could define those unconditionally and return false when network
process is not enabled, but if we can probably do it in a follow up patch to
not block this one.