[webkit-reviews] review granted: [Bug 125417] [GTK] Do not skip attributes with only custom setter : [Attachment 218696] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 125417: [GTK] Do not skip attributes with only custom setter
https://bugs.webkit.org/show_bug.cgi?id=125417

Attachment 218696: Patch
https://bugs.webkit.org/attachment.cgi?id=218696&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218696&action=review


> Source/WebCore/ChangeLog:9
> +	   * bindings/gobject/GNUmakefile.am: Generate
> +	   WebKitDOMMediaController that is now required by an attribute

This could be a longer line =P

> Source/WebCore/ChangeLog:11
> +	   * bindings/gobject/WebKitDOMCustom.cpp: Remove mothods that are now
generated.

*mothods

> Source/WebCore/ChangeLog:16
> +	   (SkipAttribute): Do not skip attributes having a custom setter.

Can you change the description to say we will now generate getters for
properties that have custom setters? I was confused for a while.