[webkit-reviews] review granted: [Bug 125403] [Cocoa] Make WKWebProcessPlugInBrowserContextController work with WKObject wrapping : [Attachment 218675] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 7 21:20:03 PST 2013


mitz at webkit.org <mitz at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 125403: [Cocoa] Make WKWebProcessPlugInBrowserContextController work with
WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=125403

Attachment 218675: Patch
https://bugs.webkit.org/attachment.cgi?id=218675&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218675&action=review


> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:89
> +-
(id)_initWithPrincipalClassInstance:(id<WKWebProcessPlugIn>)principalClassInsta
nce bundle:(InjectedBundle&)bundle

Can you add a space before the < while you’re here?

>
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:3
5
> +-
(id)_initWithPrincipalClassInstance:(id<WKWebProcessPlugIn>)principalClassInsta
nce bundle:(WebKit::InjectedBundle&)bundle;

Ditto.


More information about the webkit-reviews mailing list