[webkit-reviews] review granted: [Bug 125252] Fold typedArray.length if typedArray is constant : [Attachment 218663] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 7 17:30:03 PST 2013


Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 125252: Fold typedArray.length if typedArray is constant
https://bugs.webkit.org/show_bug.cgi?id=125252

Attachment 218663: the patch
https://bugs.webkit.org/attachment.cgi?id=218663&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218663&action=review


> Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:126
> +    SamplingRegion samplingRegion("DFG Strength Reduction Phase");
> +    return runPhase<StrengthReductionPhase>(graph);

Given how often these two lines of code go together, perhaps we should make
runPhase<> make the SamplingRegion at some point.


More information about the webkit-reviews mailing list