[webkit-reviews] review granted: [Bug 125366] Add missing ENABLE(DRAG_SUPPORT) guards for DragData and its clients : [Attachment 218641] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brian Burg <burg at cs.washington.edu>'s
request for review:
Bug 125366: Add missing ENABLE(DRAG_SUPPORT) guards for DragData and its
clients
https://bugs.webkit.org/show_bug.cgi?id=125366

Attachment 218641: patch
https://bugs.webkit.org/attachment.cgi?id=218641&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218641&action=review


> Source/WebCore/ChangeLog:9
> +	   consumer of all of these methods is DragControler, which is guarded.


Typo: DragControler with one l

> Source/WebCore/html/FileInputType.h:70
> +#if ENABLE(DRAG_SUPPORT)
>      virtual bool receiveDroppedFiles(const DragData&) OVERRIDE;
> +#endif

Would be nice to have this paragraphed separately instead of in the middle of
unconditional functions.

> Source/WebCore/html/InputType.h:249
> +#if ENABLE(DRAG_SUPPORT)
>      // Should return true if the given DragData has more than one dropped
files.
>      virtual bool receiveDroppedFiles(const DragData&);
> +#endif

Would be nice to have this paragraphed separately instead of in the middle of
unconditional functions.

> Source/WebCore/platform/win/DragDataWin.cpp:255
> +

Extra blank line at the end of this file.