[webkit-reviews] review denied: [Bug 125357] Strip out extraneous logging from AppleGVA in media tests. : [Attachment 218608] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 125357: Strip out extraneous logging from AppleGVA in media tests.
https://bugs.webkit.org/show_bug.cgi?id=125357

Attachment 218608: Patch
https://bugs.webkit.org/attachment.cgi?id=218608&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218608&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:294
> +	   test_input.is_media_test = self._port.is_media_test(test_input)

I don't think this logging filtering needs to be restricted to media tests.

> Tools/Scripts/webkitpy/port/driver.py:81
> +    strip_media_logging_patterns.append((re.compile('AVF info:.*\n'), ''))
> +    strip_media_logging_patterns.append((re.compile('GVA info:.*\n'), ''))

You could fold these two regexps together.

I think these regexps should go into a platform-specific python file, since
it's platform logging that you're filtering.