[webkit-reviews] review granted: [Bug 125351] Clean up the includes of RenderBlock.h : [Attachment 218605] Patch - updated changelog

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 125351: Clean up the includes of RenderBlock.h
https://bugs.webkit.org/show_bug.cgi?id=125351

Attachment 218605: Patch - updated changelog
https://bugs.webkit.org/attachment.cgi?id=218605&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218605&action=review


One small comment, but I’m going to do commit-queue+ anyway.

> Source/WebCore/rendering/RenderBlock.h:42
> +#if ENABLE(CSS_SHAPES)
> +class ShapeInsideInfo;
> +class ShapeValue;
> +#endif

I’m not sure we need to put forward declarations into #if statements. There is
a small benefit (compile error if we use them by accident), but it looks ugly
and the benefit is really small.

If we do keep the #if then better to add a blank line so it can be a separate
“code paragraph”.